feat: Add comma-separation to ARIA labels#9505
Merged
gonfunko merged 2 commits intoadd-screen-reader-support-experimentalfrom Dec 3, 2025
Merged
feat: Add comma-separation to ARIA labels#9505gonfunko merged 2 commits intoadd-screen-reader-support-experimentalfrom
gonfunko merged 2 commits intoadd-screen-reader-support-experimentalfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
github-actions
bot
added
PR: feature
grega
force-pushed
the
feat/add-aria-label-commas
branch
from
64bf1ed to
ced457e
Compare
Contributor
|
This looks great, thanks! |
gonfunko
reviewed
Dec 3, 2025
core/block_svg.ts
Outdated
Comment on lines
2144
to
2148
| const commaSeparatedSummary = | ||
| spokenParts.length <= 1 | ||
| ? (spokenParts[0] ?? '') | ||
| : spokenParts[0] + ', ' + spokenParts.slice(1).join(', '); | ||
|
|
Contributor
There was a problem hiding this comment.
Perhaps I'm missing something but it seems like this could just be const commaSeparatedSummary = spokenParts.join(', ');?
Member
Author
There was a problem hiding this comment.
Yep you're right, I was initially thinking the first element in the array might need to be treated differently (especially if it's the only element), but .join(', ') already handles that in exactly the same way with no need for the rest. I'll push a change up...
Member
Author
There was a problem hiding this comment.
Would you prefer me to rebase so we have a single feat: ... commit?
github-actions
bot
added
PR: feature
gonfunko
approved these changes
Dec 3, 2025
gonfunko
merged commit 27372a6
into
add-screen-reader-support-experimental
8 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes: #9494
Proposed Changes
Adds comma separation between "labels" and "inputs", results in aria-labels being transformed such as:
And: