fix: Remove extra image ARIA properties for drop-down fields (experimental)#9478
Merged
BenHenning merged 1 commit intoRaspberryPiFoundation:add-screen-reader-support-experimentalfrom Nov 20, 2025
Conversation
BenHenning
changed the base branch from
develop
to
add-screen-reader-support-experimental
Collaborator
Author
|
PTAL @rachel-fenichel. |
rachel-fenichel
approved these changes
Nov 20, 2025
Collaborator
rachel-fenichel
left a comment
rachel-fenichel
left a comment
There was a problem hiding this comment.
LGTM.
I appreciate that you've got all of the infrastructure set up and now these changes are just a line or two.
BenHenning
commented
Nov 20, 2025
Collaborator
Author
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Self-reviewed spot check to make sure only the changes I want are in the PR. :)
BenHenning
merged commit 7a3af80
into
RaspberryPiFoundation:add-screen-reader-support-experimental
21 of 22 checks passed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9461
Proposed Changes
Remove image-specific ARIA properties (role and label) for the current selected item in
FieldDropdown.Reason for Changes
This intentionally changes a behavior introduced in #9384 because the alternative ARIA behavior works better. As the images in #9461 show the actual focus outline when the current drop-down value has ARIA properties goes to that element (separate from active focus in this case) since the screen reader will read out those properties. However, this makes the reader lose context on the combo box itself.
This basically goes away from leveraging active descendant (though that's still necessary for correct combo box implementation) and just forces the label in a way that keeps the combo box context. Text-based combo boxes already do this, so this change simply brings image-based items in alignment with text combo box behaviors.
Test Coverage
No new automated tests are needed for this experimental change. Manual testing was done via core Blockly's advanced playground (using the 'test blocks' toolbox).
Documentation
No documentation changes are needed.
Additional Information
None.