fix: Ensure field ARIA labels are correct for invalid values (experimental)#9469
Merged
BenHenning merged 3 commits intoRaspberryPiFoundation:add-screen-reader-support-experimentalfrom Nov 19, 2025
Conversation
1 task
Collaborator
|
LGTM once you fix that commit lint issue. |
Collaborator
Author
|
This is a very odd failure that's completely unrelated to the PR and the branch: npm ci
shell: /usr/bin/bash -e {0}
env:
PR_TITLE: fix: Ensure field ARIA labels are correct for invalid values (experimental)
npm error code EUSAGE
npm error
npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm error
npm error Missing: fsevents@2.3.3 from lock file
npm error
npm error Clean install a project
npm error
npm error Usage:
npm error npm ci
npm error
npm error Options:
npm error [--install-strategy <hoisted|nested|shallow|linked>] [--legacy-bundling]
npm error [--global-style] [--omit <dev|optional|peer> [--omit <dev|optional|peer> ...]]
npm error [--include <prod|dev|optional|peer> [--include <prod|dev|optional|peer> ...]]
npm error [--strict-peer-deps] [--foreground-scripts] [--ignore-scripts] [--no-audit]
npm error [--no-bin-links] [--no-fund] [--dry-run]
npm error [-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]
npm error [--workspaces] [--include-workspace-root] [--install-links]
npm error
npm error aliases: clean-install, ic, install-clean, isntall-clean
npm error
npm error Run "npm help ci" for more info
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2025-11-18T23_36_55_509Z-debug-0.logIt's also consistently failing. |
…aria-label-for-invalid-field-value
Collaborator
Author
|
Okay it's failing for the other checks. This is a change in GitHub's |
1 task
Collaborator
Author
|
Filed #9475 to track. |
1 task
…aria-label-for-invalid-field-value
Collaborator
Author
|
Yay looks like CI is behaving like normal again (with the expected failure). PTAL when convenient @rachel-fenichel. |
rachel-fenichel
approved these changes
Nov 19, 2025
Collaborator
Author
|
Thanks for the quick reviews! |
141e28d
into
RaspberryPiFoundation:add-screen-reader-support-experimental
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9466
Proposed Changes
Ensures
FieldInput's ARIA labels are recomputed when an invalid value is attempted to be set.Reason for Changes
Previously the
FieldInputwould continuously update its ARIA label as the value changed, including for invalid values. If the editor was cancelled this would correctly revert but if an invalid value was attempted to be saved then it would cancel the update but not correct the ARIA label.Test Coverage
No new tests are needed for this experimental change. This has been manually verified locally using
FieldNumberin Core's advanced playground.Documentation
No documentation changes are needed for this experimental change.
Additional Information
None.