fix: Make up/previous navigation consistent with down/next.#9437
Merged
gonfunko merged 2 commits intoadd-screen-reader-support-experimentalfrom Oct 27, 2025
Merged
fix: Make up/previous navigation consistent with down/next.#9437gonfunko merged 2 commits intoadd-screen-reader-support-experimentalfrom
gonfunko merged 2 commits intoadd-screen-reader-support-experimentalfrom
Conversation
maribethb
approved these changes
Oct 24, 2025
Contributor
|
I think a similar set of tests is failing on my PR against this branch. Not sure what's up with them, although at least this PR is plausible that some of the tests need updating. |
Contributor
Author
|
Fixed the tests in RaspberryPiFoundation/blockly-keyboard-experimentation#766, which should fully pass once this is merged. |
7e77b10
into
add-screen-reader-support-experimental
11 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes RaspberryPiFoundation/blockly-keyboard-experimentation#762
Proposed Changes
This PR modifies the locations that are visited when navigating using the up arrow key to match those that are visited by the down arrow key, but in reverse. Specifically, when navigating backwards, we now: