fix: Fix exception thrown when FieldDropdown subclasses don't have a textual label.#9401
Merged
gonfunko merged 1 commit intoadd-screen-reader-support-experimentalfrom Oct 3, 2025
Merged
Conversation
…a textual label.
maribethb
approved these changes
Oct 3, 2025
gonfunko
merged commit 0eec0e0
into
add-screen-reader-support-experimental
15 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9400
Proposed Changes
This PR checks for the presence of
this.textElement_before attempting to set ARIA attributes on it inFieldDropdown. The getter it had been using throws if there is no text element, and someFieldDropdownsubclasses (namelyFieldColour) do not have one, in this particular case because a colour swatch is shown rather than a textual label.