fix: improve aria markup for toolboxes #9398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
approved these changes
Oct 2, 2025
5 tasks
maribethb
merged commit bf576d5
into
RaspberryPiFoundation:add-screen-reader-support-experimental
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9293
Proposed Changes
aria-activedescendantstatearia-posinsetaria-ownsaria-selected=falseReason for Changes
There is a comment with justification for each of these things in the linked issue. I've verified that removing the active-descendant state and the aria-owns state does not change the screenreader output, and removing the posinset state improves the output (in my opinion, as discussed in the issue)
Test Coverage
Documentation
Additional Information