fix: Toolbox & Flyout ARIA positions (experimental)#9394
Merged
BenHenning merged 2 commits intoRaspberryPiFoundation:add-screen-reader-support-experimentalfrom Oct 1, 2025
Conversation
1 task
gonfunko
reviewed
Oct 1, 2025
gonfunko
approved these changes
Oct 1, 2025
5 tasks
Also, remove unnecessary isFocusableNode() calls in WorkspaceSvg.
BenHenning
commented
Oct 1, 2025
Collaborator
Author
BenHenning
left a comment
There was a problem hiding this comment.
Self-review latest.
Collaborator
Author
|
I don't think the latest change needs another review pass since it's just adding a TODO and cleaning up redundant |
76c7345
into
RaspberryPiFoundation:add-screen-reader-support-experimental
8 of 9 checks passed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9386
Fixes part of #9293
Proposed Changes
Addresses #9386 through a number of changes:
WorkspaceSvgonly recomputed its ARIA properties when one of its blocks self-registered which doesn't account for labels or buttons).FlyoutButtons.FlyoutButtonto use a nested structure oftreeitemthenbuttonin order to actually count correctly in the tree and still be an interactive button. The readout experience is actually better now on ChromeVox, as well, since it reads out both 'Button' and 'Tree item' which is interesting. It seems screen readers are designed to look for this pattern but it only works if set up in a very particular way.Reason for Changes
Most of the changes here fixed incidental problems noticed while trying to address #9386 (such as the variables category not correctly accounting for the 'Create variable' button in the count, or not having the correct labels). Much of the count issues in the original issue were caused by a combination of missing some flyout items, and trying to compute the labels too early (i.e. before the categories were fully populated).
Test Coverage
Since this is an experimental change, no new tests were added.
Documentation
No documentation changes are directly needed here.
Additional Information
None.