fix: Avoid creating redundant a11y tree nodes when selecting a block.#9363
Merged
gonfunko merged 1 commit intoadd-screen-reader-support-experimentalfrom Sep 15, 2025
Merged
Conversation
BenHenning
approved these changes
Sep 15, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
This clone has caused me multiple problems in the past, so this is a much cleaner and future-proof way to address it. Thanks @gonfunko!
gonfunko
merged commit 3fdfe47
into
add-screen-reader-support-experimental
17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9295
Proposed Changes
This PR updates the Zelos
PathObjectselection code to not clone the block's path to create a selection outline, but instead create a new path with only the intended attributes duplicated. This prevents duplicate nodes from becoming part of the accessibility tree by marking this path asrole="presentation"rather than bringing over their existing role and ARIA attribute values.