refactor(VariableMap): Stop using deprecated wrapper methods#9340
Merged
tashee merged 4 commits intoRaspberryPiFoundation:developfrom Sep 24, 2025
Merged
refactor(VariableMap): Stop using deprecated wrapper methods#9340tashee merged 4 commits intoRaspberryPiFoundation:developfrom
tashee merged 4 commits intoRaspberryPiFoundation:developfrom
Conversation
cpcallen
reviewed
Sep 4, 2025
Collaborator
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
Looks good, but a few small fixes.
Collaborator
|
I see the Keyboard Navigation Automated Tests have failed. Unfortuantely one of those tests is really flaky. You should just re-run it until it passes. I'll let you investigate the Node.js CI / build test failure. Lint failure was due to one use of |
Co-authored-by: Christopher Allen <cpcallen+github@gmail.com>
cpcallen
approved these changes
Sep 24, 2025
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes 8945 (#8945)
Proposed Changes
Replaced deprecated wrapper methods