fix: Correct the alignment of narrow text in input fields.#9327
Merged
fix: Correct the alignment of narrow text in input fields.#9327
Conversation
RoboErikG
approved these changes
Aug 20, 2025
Contributor
RoboErikG
left a comment
RoboErikG
left a comment
There was a problem hiding this comment.
One comment on naming/comments but otherwise LGTM.
gonfunko
added a commit
that referenced
this pull request
Aug 28, 2025
* fix: Correct the alignment of narrow text in input fields. * chore: Clarify purpose of first argument to positionTextElement_().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9069
Proposed Changes
This PR fixes a bug that caused narrow text values in Zelos input fields to be slightly misaligned horizontally from the center. Input fields have a minimum width, and if the measured width of the text was less than that, it was positioned incorrectly. I also adjusted a couple places that were manually setting the
widthattribute of the field size and bypassing the minimum size enforcement as a result; this wasn't a root cause, but could lead to tricky bugs down the line.