Conversation
cpcallen
approved these changes
Aug 22, 2025
Collaborator
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
Sorry I accidentally sat on this review for such a long time!
gonfunko
added a commit
that referenced
this pull request
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes RaspberryPiFoundation/blockly-samples#2587
Proposed Changes
This PR updates field registration to not throw if a field is registered twice. This behavior is optional on the main registry, but is not exposed on the field registry. I considered making it optional here as well and propagating that value through, but I can't think of a reasonable case where, when you register a field, you want it to throw. I assume this was done to warn in case of accidental conflicts, but throwing seems aggressive for that vs a
console.log(), and in the case of fields in particular where e.g. a field might be subclassed with the subclasses distributed as packages with no knowledge of each other, the registration code may not even be aware that it would need to allow re-registration.