refactor: Make InsertionMarkerPreviewer's block serialization amenable to subclassing.#9282
Merged
refactor: Make InsertionMarkerPreviewer's block serialization amenable to subclassing.#9282
InsertionMarkerPreviewer's block serialization amenable to subclassing.#9282Conversation
…ble to subclassing.
RoboErikG
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes part of gonfunko/scratch-blocks#193
Proposed Changes
This PR refactors
InsertionMarkerPreviewerto make the serialization of a block to JSON for use as an insertion marker overridable in a subclass. Previously, this was done in a private method which also did various other setup tasks. This meant that subclasses could not practically change the configuration options passed toserialization.blocks.save(), whereas they can now override the newserializeBlockToInsertionMarker()method to do so.