fix: Allow overriding VariableModel via options.plugins.#9257
Merged
fix: Allow overriding VariableModel via options.plugins.#9257
VariableModel via options.plugins.#9257Conversation
gonfunko
force-pushed
the
inject-variable-model
branch
from
4486fb5 to
39dcb45
Compare
rachel-fenichel
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9256
Proposed Changes
This PR updates
VariableMapto retrieve theVariableModelclass to be used based on the injectionoptions.plugins. Previously, this could only be overridden by manually registering an alternative implementation with the registry as the default implementation.