feat: Add support for keyboard navigation to/from block comments.#9227
Merged
feat: Add support for keyboard navigation to/from block comments.#9227
Conversation
gonfunko
changed the title
RoboErikG
reviewed
Jul 11, 2025
RoboErikG
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9166 and part of RaspberryPiFoundation/blockly-keyboard-experimentation#636.
Proposed Changes
This PR adds support for keyboard navigation to/from block comments. To that end:
TextInputBubbleis refactored to reuseCommentEditor(also used by workspace comments) to handle text editingA corresponding change will be needed in keyboard-experiment, and tests will be added there.