refactor(CSS): move box-sizing from keyboard nav plugin to core/css.ts#9201
Merged
cpcallen merged 1 commit intoRaspberryPiFoundation:developfrom Jul 7, 2025
Merged
Conversation
Collaborator
Author
|
@microbit-matt-hillsdon: Please take a look at this and RaspberryPiFoundation/blockly-keyboard-experimentation#637. |
Collaborator
|
NB: It may be nice to link to the issues from here to connect the histories for future referencing. |
This was referenced Jul 4, 2025
Apply box-sizing to all of Blockly (and thereby obviate the need to apply it to .blocklyHtmlInput in particular.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Part of RaspberryPiFoundation/blockly-keyboard-experimentation#595
Proposed Changes
Add
box-sizing: border-boxto the existing.blocklyToolboxstyling incore/css.ts.Reason for Changes
The following "CSS reset" was added to the plugin playground by @microbit-matt-hillsdon in RaspberryPiFoundation/blockly-keyboard-experimentation#511 to fix an issue with the toolbox focus indicator border being misplaced:
This would be a pretty good default (explanation) for Blockly but that would definitely be a breaking change, so for now apply it only to the
blocklyToolboxdiv.Test Coverage
Manually verified it has the desired effect on the toolbox focus indicator (after removing corresponding styling from plugin's
test/index.html, of course).Additional Information
box-sizingstyling to be removed from the keyboard-nav plugin by refactor(CSS): move plugin styling fromtest/index.htmltosrc/index.jsblockly-keyboard-experimentation#637box-sizing: border-boxthe default for Blockly v13 #9205