fix: Don't auto-close flyout for new vars

core/flyout_base.ts

@@ -22,6 +22,7 @@
 import {FlyoutMetricsManager} from './flyout_metrics_manager.js';
 import {FlyoutNavigator} from './flyout_navigator.js';
 import {FlyoutSeparator, SeparatorAxis} from './flyout_separator.js';
+import { getFocusManager } from './focus_manager.js';
 import {IAutoHideable} from './interfaces/i_autohideable.js';
 import type {IFlyout} from './interfaces/i_flyout.js';
 import type {IFlyoutInflater} from './interfaces/i_flyout_inflater.js';
@@ -615,6 +616,10 @@
    *     toolbox definition, or a string with the name of the dynamic category.
    */
   show(flyoutDef: toolbox.FlyoutDefinition | string) {
+    const previouslyFocusedNode = getFocusManager().getFocusedNode();
+    const hadFocusedItem =
+      this.getContents().some(
+        (item) => item.getElement() === previouslyFocusedNode);
     this.workspace_.setResizesEnabled(false);
     this.hide();
     this.clearOldBlocks();
@@ -655,6 +660,14 @@
       }
     };
     this.workspace_.addChangeListener(this.reflowWrapper);
+
+    // It's difficult to restore the actual element that was focused since
+    // everything gets recreated (and it may no longer exist). Instead, if the
+    // flyout previously held focus then force it to focus the first element.
+    const contents = this.getContents();
+    if (hadFocusedItem && contents.length > 0) {
+      getFocusManager().focusNode(contents[0].getElement());
+    }
   }
 
   /**

core/variables.ts

@@ -9,6 +9,7 @@
 import type {Block} from './block.js';
 import {Blocks} from './blocks.js';
 import * as dialog from './dialog.js';
+import { getFocusManager } from './focus_manager.js';
 import {isLegacyProcedureDefBlock} from './interfaces/i_legacy_procedure_blocks.js';
 import {isVariableBackedParameterModel} from './interfaces/i_variable_backed_parameter_model.js';
 import {IVariableModel, IVariableState} from './interfaces/i_variable_model.js';
@@ -519,6 +520,8 @@
   defaultText: string,
   callback: (p1: string | null) => void,
 ) {
+  const returnEphemeralFocus =
+    getFocusManager().takeEphemeralFocus(document.body);
   dialog.prompt(promptText, defaultText, function (newVar) {
     // Merge runs of whitespace.  Strip leading and trailing whitespace.
     // Beyond this, all names are legal.
@@ -529,6 +532,7 @@
         newVar = null;
       }
     }
+    returnEphemeralFocus();
     callback(newVar);
   });
 }

core/workspace_svg.ts

@@ -43,7 +43,7 @@
 import {Gesture} from './gesture.js';
 import {Grid} from './grid.js';
 import {MutatorIcon} from './icons/mutator_icon.js';
 import {isAutoHideable} from './interfaces/i_autohideable.js';
 import type {IBoundedElement} from './interfaces/i_bounded_element.js';
 import {IContextMenu} from './interfaces/i_contextmenu.js';
 import type {IDragTarget} from './interfaces/i_drag_target.js';
@@ -2856,11 +2856,12 @@
       // Only hide the flyout if the flyout's workspace is losing focus and that
       // focus isn't returning to the flyout itself, the toolbox, or ephemeral.
       if (getFocusManager().ephemeralFocusTaken()) return;
       const flyout = this.targetWorkspace.getFlyout();
       const toolbox = this.targetWorkspace.getToolbox();
       if (toolbox && nextTree === toolbox) return;
-      if (toolbox) toolbox.clearSelection();
-      if (flyout && isAutoHideable(flyout)) flyout.autoHide(false);
+      // TODO: Figure out how to fix this.
+      // if (toolbox) toolbox.clearSelection();
+      // if (flyout && isAutoHideable(flyout)) flyout.autoHide(false);
     }
   }