fix: clear touch identifier on comment text area pointerdown#9172
Merged
maribethb merged 1 commit intoRaspberryPiFoundation:developfrom Jun 26, 2025
Merged
Conversation
Collaborator
|
I think an equivalent fix is needed for the block comment case in |
riknoll
force-pushed
the
dev/riknoll/clear-touch-textarea
branch
from
959064a to
d77f777
Compare
maribethb
approved these changes
Jun 26, 2025
microbit-matt-hillsdon
added a commit
to microbit-matt-hillsdon/pxt
that referenced
this pull request
Jun 27, 2025
riknoll
pushed a commit
to microsoft/pxt
that referenced
this pull request
Jun 27, 2025
* Temporary fix for preview branch to fix flyout navigation * Improve navigation behaviour between toolbox and flyout Re-focus previously focused block in the flyout if possible. * Add context menu CSS, drop old workaround The workaround equivalent shipped in 12.1.0. * Fix move keyboard shortcut name The format was aligned with the others in the plugin. * Handle Blockly focus for blocks with plus / minus buttons These buttons are removed from the DOM and re-rendered when interacted with. As a result focus is lost. This change re-focuses the block when this happens. * Don't manage focus for +/- buttons for initial render * Ignore the previous flyout node if the flyout was closed * Ignore drag and selected events in shouldEventHideFlyout * Also ignore BLOCK_MOVE event for shouldEventHideFlyout * Focus block after interaction with + / - buttons This includes the expand / collapse buttons for functions. * Somewhat crufty icon focus fixes. Hard to tell if the opacity is intended, it's quite odd really but would be a meaningful visual change. * Fix moving caret in block comments Aligns with RaspberryPiFoundation/blockly#9153 Workspace comments need a separate fix from Blockly. * Revert unintended change * Add translations used by the keyboard navigation plugin. * Update to Blockly beta releases * Clear touch identifier as per Blockly fix See RaspberryPiFoundation/blockly#9172 --------- Co-authored-by: Robert Knight <robert@microbit.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9170
Fixes #9108
Proposed Changes
Clear the cached touch identifier inside the pointerdown event handler inside the
CommentViewReason for Changes
The pointerdown event handler inside of
CommentViewusesconditionalBindto bind the event listener. Inside that event listener, it then callsstopPropagationto prevent the event from bubbling. As a result a touch identifier is registered but it never gets cleared which prevents all further pointer events from firing on the workspaceTest Coverage
Tested in playground locally.
Documentation
Additional Information
@microbit-matt-hillsdon FYI