fix: focus after drag and deleting comments#9074
Merged
maribethb merged 2 commits intoRaspberryPiFoundation:developfrom May 20, 2025
Merged
fix: focus after drag and deleting comments#9074maribethb merged 2 commits intoRaspberryPiFoundation:developfrom
maribethb merged 2 commits intoRaspberryPiFoundation:developfrom
Conversation
rachel-fenichel
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8825
Proposed Changes
RenderedWorkspaceCommentdeclare that it implementsIFocusableNode, it already did this so idk why it didn't say it didReason for Changes
Test Coverage
There are tests for this in keyboard-nav which I'll update when I remove the extra delete handling code there. It's a whole can of worms to move those tests into core, so for now, they'll live in keyboard-nav but will move into core with many of the other keyboard nav tests post-launch
Documentation
Additional Information