fix: focus something after deleting a block#9073
Merged
maribethb merged 1 commit intoRaspberryPiFoundation:developfrom May 20, 2025
Merged
fix: focus something after deleting a block#9073maribethb merged 1 commit intoRaspberryPiFoundation:developfrom
maribethb merged 1 commit intoRaspberryPiFoundation:developfrom
Conversation
rachel-fenichel
approved these changes
May 20, 2025
Collaborator
|
@maribethb do you think the behaviour is right for shadow blocks, or should it be a special case? Screen.Recording.2025-05-21.at.15.42.19.mov |
Contributor
Author
|
No, we should probably be smarter in a couple of ways. Christopher had some suggestions here RaspberryPiFoundation/blockly-keyboard-experimentation#254 and we also have #9075 that needs discussion. My goal was just to have the behavior not be super broken (i.e. nothing was focused before), but there's def room for improvement. I think we'll discuss these 2 bugs tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8793
Proposed Changes
Focuses the parent of a block or the workspace after deleting a block
Reason for Changes
Keyboard shortcuts stopped working if you deleted a block, because blockly wasn't focused anymore. Unblocks some testing issues in the kb experiment
Test Coverage
There are some tests in the keyboard-experiment that test this
Documentation
Additional Information