Skip to content

refactor!: Improve ability to use CSS to style Blockly.#8647

Merged
gonfunko merged 6 commits intoRaspberryPiFoundation:rc/v12.0.0from
gonfunko:css-refactor
Nov 7, 2024
Merged

refactor!: Improve ability to use CSS to style Blockly.#8647
gonfunko merged 6 commits intoRaspberryPiFoundation:rc/v12.0.0from
gonfunko:css-refactor

Conversation

@gonfunko gonfunko requested a review from a team as a code owner November 6, 2024 19:05
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: refactor labels Nov 6, 2024
@gonfunko gonfunko merged commit d804c1a into RaspberryPiFoundation:rc/v12.0.0 Nov 7, 2024
@gonfunko gonfunko deleted the css-refactor branch November 7, 2024 20:16
cpcallen added a commit to cpcallen/blockly-keyboard-experimentation that referenced this pull request Jul 3, 2025
The blocklyToolboxDiv class was renamed blocklyToolbox in
RaspberryPiFoundation/blockly#8647, fixing RaspberryPiFoundation/blockly#8343.

The references in this repository were not updated but are now
evidently obsolete: if we wanted them we'd have fixed them by now.
rachel-fenichel added a commit to RaspberryPiFoundation/blockly-keyboard-experimentation that referenced this pull request Jul 7, 2025
* chore(CSS): Remove references to defunct class blocklyToolboxDiv

The blocklyToolboxDiv class was renamed blocklyToolbox in
RaspberryPiFoundation/blockly#8647, fixing RaspberryPiFoundation/blockly#8343.

The references in this repository were not updated but are now
evidently obsolete: if we wanted them we'd have fixed them by now.

* refactor(CSS): move box-sizing to core/css.ts

Also apply only to .blocklyToolbox instead of *

* refactor(CSS): move .blocklyDeleteIcon to src/index.ts

* refactor(CSS): move variables to src/index.ts

Also move them from html to .injectionDiv.

* refactor(CSS): move focus-related styling to src/index.ts

* fixup delete icon

* refactor(CSS): move context menu styling to src/index.ts

* chore: move CSS registration to a static method

* chore: add CSS registration call in webdriver tests

* chore: format

---------

Co-authored-by: Christopher Allen <cpcallen+git@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Used to mark a PR or issue that changes our public APIs. PR: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants