feat: add the block's type as a CSS class to the block's root SVG#8428
Merged
BeksOmega merged 2 commits intoRaspberryPiFoundation:rc/v12.0.0from Jul 31, 2024
Merged
feat: add the block's type as a CSS class to the block's root SVG#8428BeksOmega merged 2 commits intoRaspberryPiFoundation:rc/v12.0.0from
BeksOmega merged 2 commits intoRaspberryPiFoundation:rc/v12.0.0from
Conversation
BeksOmega
suggested changes
Jul 30, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
Based on the other PR for this issue, I think this is going to fail some unit tests when the prototypeName doesn't exist. Could you wrap this in a check that it exists before trying to apply it?
CodeMaverick2
force-pushed
the
issue3
branch
2 times, most recently
from
ddb69b6 to
d5faba0
Compare
BeksOmega
changed the title
BeksOmega
approved these changes
Jul 30, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
Looks great! Once this passes CI I'll get it merged =)
Contributor
Author
|
@BeksOmega Sure, If any changes needed do tell me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue -> #8268
Fixes #8268
Description
This PR adds the
prototypeNameas a CSS class to the SVG group element of each block in theBlockSvgconstructor. This enhancement allows for easier styling and identification of blocks based on their prototype.Changes
BlockSvgconstructor to add theprototypeNameas a CSS class tothis.svgGroup_usingdom.addClass().Benefits
This change is backwards-compatible and provides a hook for future enhancements or debugging.