Skip to content

Conversation

@Shreshthaaa
Copy link
Contributor

Details :
Added blocklyNotDeletable CSS class to block_svg.

Fixes : #8265

@Shreshthaaa Shreshthaaa requested a review from a team as a code owner July 17, 2024 18:51
@Shreshthaaa Shreshthaaa requested a review from cpcallen July 17, 2024 18:51
@google-cla
Copy link

google-cla bot commented Jul 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 17, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@Shreshthaaa Shreshthaaa changed the title feat : added 'blocklyNotDeletable' class to block_svg #8265 feat: added 'blocklyNotDeletable' class to block_svg Jul 17, 2024
@github-actions github-actions bot added the PR: feature Adds a feature label Jul 17, 2024
@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen July 18, 2024 15:45
@BeksOmega BeksOmega assigned BeksOmega and unassigned cpcallen Jul 18, 2024
@Shreshthaaa
Copy link
Contributor Author

Hi @BeksOmega, I wanted to check if there's any update or if any further action is needed from my side.
Thank you!

@Shreshthaaa
Copy link
Contributor Author

Hey @BeksOmega, I have created a new PR for the same issue. Last one had some issues.
Kindly check the new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: feature Adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants