feat: Add a blocklyCollapsed CSS class to collapsed blocks' root SVG (#8264)#8308
Merged
BeksOmega merged 2 commits intoRaspberryPiFoundation:rc/v12.0.0from Jul 22, 2024
Merged
Conversation
github-actions
bot
added
PR: feature
BeksOmega
approved these changes
Jul 11, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
This looks great! Thank you for the fix =)
Once this passes CI I'll get it merged!
Contributor
|
Looks like this is failing formatting. Please fix the same way I suggested on the other PR! |
BeksOmega
suggested changes
Jul 12, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
Marking this as changes requested
Contributor
|
Heya @ga-fleury Are you still interested in working on this? |
Contributor
Author
|
@BeksOmega format changes pushed |
BeksOmega
approved these changes
Jul 22, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
This looks great =) Thanks for your work on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8264
feat: Add a blocklyCollapsed CSS class to collapsed blocks' root SVG (#8264)