fix: correctly report the pre-resize-drag size to workspace comment size change listeners #8240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize change listeners
BeksOmega
approved these changes
Jul 2, 2024
BeksOmega
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ize change listeners
The basics
The details
Proposed Changes
This PR stores the workspace comment size at the start of a drag on the resize handle, and reports that value to size change listeners. Previously, because the comment was continuously resized during the drag, but size change events were only fired at the end, the "old" comment size calculated in the method that fires the size change event was identical to the new size, so size change listeners were misinformed.