-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
RaspberryPiFoundation/blockly-keyboard-experimentation
#773Description
Check for duplicates
- I have searched for similar issues before opening a new one.
Description
There is currently a check for whether a block is a simple reporter with a full block field, however, this code only checks the first field in the input. There are instances in MakeCode where it is not the first field that is the full block field. Please see the example below where the first field is just the text "melody" and the second field is the full block field.
I think that at least for shadow blocks, the check needs to extend to all of the fields. This same change would also have to be applied to getFocusableElement where the same check is made.
Reproduction steps
Priority
No response
Stack trace
Screenshots
No response
Browsers
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done