-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
good first issuehelp wantedExternal contributions actively solicitedExternal contributions actively solicitedissue: feature requestDescribes a new feature and why it should be addedDescribes a new feature and why it should be added
Milestone
Description
To Fix
- Add an
addClassmethod to the BlockSvg class, that takes in a passed string, and callsdom.addClasswith thethis.svgGroup_to add it as a CSS class on the block. - Add a
removeClassmethod to the BlockSvg class, that takes in a passed string, and callsdom.removeClassClasswith thethis.svgGroup_. - Refactor any calls in the BlockSvg class to
dom.addClasswiththis.svgGroup_to callthis.addClassinstead. - Refactor any calls in the BlockSvg class to
dom.removeClasswiththis.svgGroup_to callthis.removeClassinstead.
The PR to fix this should be made against the rc/v12.0.0 branch.
To work on this issue, please comment below asking to be assigned.
Metadata
Metadata
Assignees
Labels
good first issuehelp wantedExternal contributions actively solicitedExternal contributions actively solicitedissue: feature requestDescribes a new feature and why it should be addedDescribes a new feature and why it should be added