Toolbox search broken in Blockly v12

[xXBuilderBXx]

Check for duplicates

• I have searched for similar issues before opening a new one.

Component

Toolbox search

Description

Blockly v12.1.0

The demo is also broken https://google.github.io/blockly-samples/plugins/toolbox-search/test/index.html
No console error messages are showing either.

Reproduction steps

No response

Stack trace

Screenshots

No response

[cpcallen]

Notes for triage: This appears to be a bug in Blockly rather than in the toolbox search plugin: the plugin worked fine with v12.0 and so, since 12.1 is not a new major version and should therefore not contain any breaking changes, any issue caused by updating from v12.0 to v12.1 is a bug in Blockly, unless it can be plausibly argued that the plugin was previously relying on buggy behaviour which was fixed in v12.1.

Looking at the proposed fixes in #2578 does not IMHO make that seem like a particularly credible line of argument: the PRs changes all seem fine but also seem like changes that should not be necessary absent an intentional API change.

I propose moving this issue to the blockly repository and retitling it "Changes in v12 broke toolbox search plugin" and marking as P1, maybe P0, at least until the root cause is understood well enough to be able to estimate the blast radius. leaving this bug to track the short-term fix of the toolbox search plugin, and using the newly-opened RaspberryPiFoundation/blockly#9220 to track the larger issue.

Additional info:

Using git bisect I have determined that the toolbox-search plugin was broken by RaspberryPiFoundation/blockly#9082.

[xXBuilderBXx]

I think it's a bit of both really it's a bug in blockly because of the new v12 changes not being backwards compatible but also a bug in toolbox search because it's not using the new ifocusnode and focusmanager classes that are supported and more browser compatible.

The v12.0.0 release notes here https://github.com/google/blockly/releases says:

Revamped focus and handling selected items to be compatible with browser focus and enable keyboard navigation. This is most likely to require your attention if you have custom elements that should be keyboard navigable or if you ever set tabstops manually on Blockly components

[cpcallen]

@xXBuilderBXx: you are right that it would be good to update the plugin to use the new APIs, but there's no obvious reasons that the existing code should not continue to work with v12, and (as far as I can tell[*]) it works fine with v12.0.0 but not with v12.1.0, so that seems like a breaking change in v12.1.0 which shouldn't have happened.

[*] Please confirm if you concur, or refute this if you believe I am mistaken!