feat: support external toolbox (e.g. MakeCode) #291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakeCode's toolbox is a separate UI component (the toolbox Blockly sees is empty). Add just enough glue to get keyboard navigation working in its flyout and be able to close the flyout when we leave the toolbox.
Contributor
Author
|
Closing in favour of the approach on #358 which leaves all the messy bits on the MakeCode end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MakeCode's toolbox is a separate UI component (the toolbox Blockly sees is empty). Add just enough glue to get keyboard navigation working in its flyout and be able to close the flyout when we leave the toolbox.
This is analogous to the monkey patching that was done for the original keyboard navigation plugin (which isn't viable anymore due to better encapsulation).
One to discuss next week, but it would be really helpful to merge something like this even if we aspire to do it differently in the long term.
I've tried to clarify this a little based on a past chat discussion and it's got simpler as the plugin has evolved.