chore: move action menu to its own file #285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
requested review from
cpcallen and
gonfunko
and removed request for
a team and
gonfunko
cpcallen
approved these changes
Mar 6, 2025
| ShortcutRegistry.registry, | ||
| ); | ||
|
|
||
| interface Scope { |
Collaborator
There was a problem hiding this comment.
Perhpas this should be exported so it can be imported by the menu items that now support connection contexts (which IIRC currenlty have their own copy of this type).
This was referenced Mar 7, 2025
Collaborator
Author
|
Superseded by #314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling of #284
Moves the action menu and all of its code from
navigation.tsandnavigation_controller.tsto a new file,src/actions/action_menu.ts.This action is different from the others in that it needs a
canCurrentlyNavigatefunction rather than acanCurrentlyEditfunction for precondition checks.This PR just moves code around. It doesn't change any behaviour. Testing by running it.