feat: toasts for move/cut/copy and enter on a block #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@bmxedd do you have UX thoughts on best practices for toasts, particularly in this accessibility context? |
microbit-matt-hillsdon
force-pushed
the
toast
branch
from
f5451c3 to
7a297ca
Compare
1 task
microbit-matt-hillsdon
force-pushed
the
toast
branch
from
1b7c754 to
afea6ae
Compare
Contributor
Author
|
Rebased on #408 for now. |
microbit-matt-hillsdon
force-pushed
the
toast
branch
3 times, most recently
from
67159d4 to
b3e1be9
Compare
Merged
1 task
Contributor
|
Rebased on main and now uses the new Toast class in Blockly core. Used in the following cases:
|
The enter on a block toast shows generic help and we might consider showing it earlier if e.g. the user tabs to the workspace or otherwise focusses it by keyboard.
microbit-matt-hillsdon
force-pushed
the
toast
branch
from
25d595f to
52a8420
Compare
microbit-matt-hillsdon
changed the title
microbit-matt-hillsdon
requested review from
maribethb
and removed request for
a team
gonfunko
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enter on a block toast shows generic help and we might consider showing it earlier if e.g. the user tabs to the workspace or otherwise focusses it by keyboard.
This logically conflicts with #458 which moves some related text to Blockly.Msg but (obviously!) not the new text. We can merge in either order and clean up after or block one on the other.