Merged
Conversation
This PR picks up some of the remaining work from Elek's recent refactoring of cluster printing. It simplifies the logical flow of contig printing by reducing the number of functions. The logic is more clear about when printing happens: It now separates the cluster writing into two functions: One clusters and writes the associated files while clustering. Another function, used e.g. when reclustering, merely writes the files. This commit also: * Fixes a bunch of type errors, making the code pass typecheck * More thoroughly encodes the state into the type system: i.e. if arguments A and B are needed together, or not at all, they are condensed in a single variable of type Option[tuple[A, B]].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR picks up some of the remaining work from Elek's recent refactoring of cluster printing. It simplifies the logical flow of contig printing by reducing the number of functions.
The logic is more clear about when printing happens: It now separates the cluster writing into two functions: One clusters and writes the associated files while clustering. Another function, used e.g. when reclustering, merely writes the files.
This commit also: