[pull] main from github:main - #222
Merged
Merged
Conversation
* Update @github/copilot to 1.0.78-2 - Updated nodejs and test harness dependencies - Re-ran code generators - Formatted generated code * Fix CI breaks from the CLI 1.0.78-2 schema update The dependency bump regenerated types but left hand-written code and tests behind, breaking every language job. Five independent fixes: - Go: the CLI added a `factory` permission-request kind, so `PermissionRequestFactory` needed a `RequiresManagedApproval()` impl. Added it, and registered the new variant in the codegen shim (`PERMISSION_REQUEST_DEFINITION_NAMES`) so Go/Python/Rust all carry the `managedApprovalRequired` field consistently. - .NET: `session.start` gained `githubMcpToolConfig`, so codegen emitted a `GitHubMcpToolConfig` class colliding with the hand-written one in `dotnet/src/Types.cs` (15 CS0260/CS0102 errors). Taught the C# generator to skip nested classes whose names already exist hand-written under `dotnet/src`, mirroring the existing behavior in the Go generator. The `[JsonSerializable]` registrations are preserved. - Java: `SessionEventHandlingTest` calls generated record constructors positionally; `SessionStartEventData` gained `githubMcpToolConfig` and `AssistantMessageEventData` gained `chunkIndex`/`chunkCount`. Padded the three call sites. This also unblocks CodeQL's java-kotlin analysis. - Rust: `EventLogReadRequest` gained `agent_ids` and `direction`; added them to the three exhaustive struct literals in `tests/e2e/rpc_event_log.rs`. - Node.js: the CLI can now answer `session.factory.run`/`resume` before the run settles, so the e2e test saw `status: "running"`. `SessionFactoryApi` documents these as resolving with a terminal envelope, so both now route through a `settleFactoryRun` helper that waits for terminal state when the initial envelope is non-terminal. Correct under both old and new CLI behavior. Validated locally: go build/vet, dotnet build (src + test), mvn test-compile + spotless:check + SessionEventHandlingTest (29/29), cargo check --tests + cargo fmt --check, npm run typecheck/lint, and the full Node unit suite (363 tests). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 820d6939-ba01-4044-8ee3-c5f5b4d3f443 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 820d6939-ba01-4044-8ee3-c5f5b4d3f443
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )