Unifies the contrast number used by python and cpp to be same with matlab and Data points now show when show_error is False
#197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenNneji
force-pushed
the
contrast_plus_one
branch
from
5ead5bb to
7c15526
Compare
DrPaulSharp
reviewed
Feb 4, 2026
Collaborator
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
All looks good by and large, could you please review the jupyter notebook DSPC_custom_layers.ipynb and confirm whether you intend to make such substantial changes.
| if contrast == 1 or contrast == 3: | ||
| if contrast == 2 or contrast == 4: | ||
| output = [alloyUp, gold, SAMTAILS, SAMHEAD, CW, *BILAYER] | ||
| else: |
Collaborator
There was a problem hiding this comment.
Is it worth changing this line to elif contrast == 1 or contrast == 3: to improve clarity?
Collaborator
There was a problem hiding this comment.
Same with elsewhere in this PR.
| @@ -2,7 +2,7 @@ | |||
| "cells": [ | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": 1, | |||
| "execution_count": 25, | |||
Collaborator
There was a problem hiding this comment.
Should this line be changed?
Collaborator
There was a problem hiding this comment.
There are a few more examples in the file.
| "+-------+------------+------------------------+---------------------+----------+-------------------------------------------------------------------------------------+\n", | ||
| "| index | name | filename | function name | language | path |\n", | ||
| "+-------+------------+------------------------+---------------------+----------+-------------------------------------------------------------------------------------+\n", | ||
| "| 0 | DSPC Model | custom_bilayer_DSPC.py | custom_bilayer_DSPC | python | C:\\Users\\steve\\Documents\\Development\\python-RAT\\ratapi\\examples\\normal_reflectivity |\n", |
Collaborator
There was a problem hiding this comment.
Hmm, having either of your of my paths here isn't ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 165
Data points now show when
show_erroris False