Conversation
…view (with qtbot)
…itab view option
…ers_view correctly
…s change and accept/cancel change in properties
…it tests for LabeledSlider
…ers view window
… Needs to do proper undo process
…cessing properties
…recent Python fashion
… Modifying sliders view to work efficiently and accept changes from tables correctly. Incomplete
… properties Changed properties do not depend on assumption of loop order remains persistent
# Conflicts: # rascal2/ui/view.py # rascal2/widgets/__init__.py # rascal2/widgets/project/project.py # rascal2/widgets/project/tables.py # tests/ui/test_view.py # tests/widgets/project/test_project.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements first task of ticket Re #172, providing sliders in separate floating window, which is controlled by MDI interface.
Sliders are synchronized with appropriate fields of project column, so changes in table immediately reflected in sliders and vise wersa.
The majority of the code (except changes from merge) have been reviewed in PR #161 (up to marked by issue Re #162), but because request to merge #162 into Re #149, it is complete mess.