Fixes inconsistent model type#80
Merged
StephenNneji merged 2 commits intoRascalSoftware:masterfrom Feb 17, 2023
Merged
Conversation
StephenNneji
force-pushed
the
model_type_issue
branch
from
f19a0ce to
b6bae59
Compare
StephenNneji
changed the title
StephenNneji
force-pushed
the
model_type_issue
branch
from
b6bae59 to
379571d
Compare
DrPaulSharp
reviewed
Feb 16, 2023
Collaborator
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
Given that the domains classes are still included on the master branch I think it would be worth making these changes there also. There are five instances of 'layers' in domains related routines:
API/domainsClass/domainsClass.m: line 227 & line 277
API/domainsClass/reflContrastsClass.m: line 250
API/domainsClass/simContrastsClass.m: line 156
targetFunctions/domains_TF/domainsTF_reflectivityCalculation.m: line 66
RabiyaF
approved these changes
Feb 17, 2023
arwelHughes
added a commit
to arwelHughes/RAT_fork
that referenced
this pull request
Feb 17, 2023
Merge issue RascalSoftware#80 frin RascalSoftware/RAT
DrPaulSharp
added a commit
that referenced
this pull request
Feb 28, 2023
* Fixes broken examples * Fixes inconsistent model type (#80) * Removes domainsClass and domains_TF folders (#84) * Adds tests for the resolution class and updates docs (#86) * Adds tests and docs to the contrasts class (#88) * Fixes broken examples --------- Co-authored-by: Paul Sharp <44529197+DrPaulSharp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes uses of "Layers" as the model type.
Removes offending mex file and updates test data