Added tests and docs to custom file class#59
Merged
DrPaulSharp merged 47 commits intoRascalSoftware:masterfrom Feb 14, 2023
DrPaulSharp:test_custom_file
Merged
Added tests and docs to custom file class#59DrPaulSharp merged 47 commits intoRascalSoftware:masterfrom DrPaulSharp:test_custom_file
DrPaulSharp merged 47 commits intoRascalSoftware:masterfrom
DrPaulSharp:test_custom_file
Conversation
… get routine "get.fileCount()"
…ialiseParameters" corrected to "numParams"
…iseCustomFileClassOneRow". Also removed code setting dependent property "fileCount"
…ewParams". Also added identifiers to error messages in "customFileClass" for testing.
…omFileClass" and removed redundant routine "getCustomNames"
…licate names are matched correctly
…CustomName", and "setFileName" in "customFileClass"
… array "fileList" in routine "toStruct"
… MException for repeated errors.
…invalidNumberOfInputs.m", "nameNotRecognised.m", "invalidInput.m", "invalidOption.m"
…upport for the language "Octave" from "customFileClass.m".
…ustomFile" for the initial row of the table.
…ectClass.m", alongside tests.
utilities/exceptions/invalidInput.m
Outdated
| @@ -0,0 +1,10 @@ | |||
| classdef invalidInput < MException | |||
Collaborator
There was a problem hiding this comment.
What is the difference btw invalid type and invalid input?
Collaborator
Author
There was a problem hiding this comment.
As I was developing the exceptions Invalid input split into invalid type and invalid number of inputs. I'll remove this one and we can always readd it later if needs be.
| initialTypesCount = 1; | ||
| initialTypesAutoNameCounter = 1; | ||
| initialTypesAutoNameString = 'Row'; | ||
| exampleTable % Example Multi-Type Table for testing |
Collaborator
There was a problem hiding this comment.
I don't think there is any benefit to semicolon but its used in some classes so we have to agree a style an unify all
Collaborator
Author
There was a problem hiding this comment.
I'd spotted this as well. I'll take the semicolons out, which I prefer.
StephenNneji
approved these changes
Feb 14, 2023
This was referenced Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the class "testCustomFileClass" which sets out a suite of explicit tests for the custom file class within project class.
Adds custom RAT exceptions to utilities/exceptions and implements them in "customFileClass.m"
Tests for custom exceptions included in "testExceptions"