Adds tests for the controlsClass and renames some variables#52
Merged
StephenNneji merged 2 commits intoRascalSoftware:masterfrom Mar 3, 2023
Merged
Conversation
42 tasks
StephenNneji
force-pushed
the
controldef_class_tests
branch
from
4491b59 to
3467c62
Compare
StephenNneji
force-pushed
the
controldef_class_tests
branch
from
3467c62 to
8231267
Compare
StephenNneji
changed the title
DrPaulSharp
approved these changes
Mar 2, 2023
DrPaulSharp
approved these changes
Mar 3, 2023
StephenNneji
force-pushed
the
controldef_class_tests
branch
from
c428557 to
f2a7c2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for the controls class
Refactors controlDef.calcSldDuringFit to use boolean
Adds type check for controlDef.resamPar