Added further tests for reflectivity calculations#45
Merged
StephenNneji merged 15 commits intoRascalSoftware:masterfrom Jan 24, 2023
DrPaulSharp:testing
Merged
Added further tests for reflectivity calculations#45StephenNneji merged 15 commits intoRascalSoftware:masterfrom DrPaulSharp:testing
StephenNneji merged 15 commits intoRascalSoftware:masterfrom
DrPaulSharp:testing
Conversation
…dardTFLayersReflectivityCalculation"
… reflectivity calculations
… added tolerances to all tests
…o updated "addRatPaths.m" and "makeInputsAndOutputs.m" to account for renamed directories.
StephenNneji
approved these changes
Jan 24, 2023
Collaborator
StephenNneji
left a comment
StephenNneji
left a comment
There was a problem hiding this comment.
Thanks for the clean up
| %} | ||
|
|
||
| function testResolutionPolly(testCase) | ||
| % testResolutionPolly |
Collaborator
There was a problem hiding this comment.
Docstring's don't give useful information in tests. Please remove and you can add a comment that gives more information about the test if needed. Many of these test don't even need any comment since the test methods are named properly
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behaviour (You can also link to an open issue here)?
Explicit tests for reflectivity calculations stop at the "reflectivity_calculation" routine in "targetFunctions/reflectivity_calculation/reflectivity_calculation.m"
What kind of change does this PR introduce, does this PR introduce a breaking change?
We add tests for the "standardTF_reflectivityCalculation", "standardTF_stanLay_reflectivityCalculation", "standardTF_custLay_reflectivityCalculation", "standardTF_custXY_reflectivityCalculation", "standardTF_stanlay_single", "standardTF_custlay_single", "standardTF_custXY_single", "standardTF_stanlay_paraContrasts", "standardTF_custlay_paraContrasts", "standardTF_custXY_paraContrasts", "standardTF_stanlay_paraPoints", "standardTF_custlay_paraPoints", "standardTF_custXY_paraPoints", "RAT_parse_cells", "extractProblemParams" routines, all of which are involved in standard TF reflectivity calculations at a lower level the the routines currently tested.
Other information:
In the "testSuite" directory, the sub directory "commonFunctions_test" has been renamed "testCommonFunctions", "standardTF_reflectivityCalculationTest" has been renamed "standardTFReflectivityCalculation", and the "reflectivity_calculation" directory has been removed.