Fix exception handling#305
Merged
StephenNneji merged 2 commits intoRascalSoftware:masterfrom Jan 10, 2025
Merged
Conversation
StephenNneji
force-pushed
the
fix_exception_handling
branch
from
7c03594 to
2164e35
Compare
StephenNneji
force-pushed
the
fix_exception_handling
branch
from
2164e35 to
93c38aa
Compare
DrPaulSharp
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #297
I replaced all instances of
error(...)in the complied code, I did not replaceerror(...)in 3rdParty or Dream diagnostics.I also tested on python-RAT, passing in an invalid TF for example should now raise a ValueError instead of failing silently