Splits resampleParams into two params#263
Merged
alexhroom merged 6 commits intoRascalSoftware:masterfrom Sep 6, 2024
alexhroom:split-resample-params
Merged
Splits resampleParams into two params#263alexhroom merged 6 commits intoRascalSoftware:masterfrom alexhroom:split-resample-params
resampleParams into two params#263alexhroom merged 6 commits intoRascalSoftware:masterfrom
alexhroom:split-resample-params
Conversation
fixed typo hopefully all fixed? fixed tests again
DrPaulSharp
approved these changes
Sep 6, 2024
Collaborator
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
All looks good, a few comments to consider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see RascalSoftware/python-RAT#69 - this PR splits
resampleParamsinto two parameters,resampleMinAngleandresampleNPoints.