Fixes a typo in projectClassToR1#250
Merged
alexhroom merged 3 commits intoRascalSoftware:masterfrom Jul 30, 2024
alexhroom:patch-1
Merged
Fixes a typo in projectClassToR1#250alexhroom merged 3 commits intoRascalSoftware:masterfrom alexhroom:patch-1
projectClassToR1#250alexhroom merged 3 commits intoRascalSoftware:masterfrom
alexhroom:patch-1
Conversation
alexhroom
changed the title
projectClassToR1
Collaborator
|
Yes - conversion to and from R1 files comes up in both the test data and also the examples. As you've got the tests to pass I'm pretty confident you've caught it everywhere. |
DrPaulSharp
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
projectClassToR1function misspells the R1 struct fieldresolution_constrasreslution_constr, meaning that the fieldresolution_constris missing from the resulting R1 struct. This PR fixes that. (for some reason the test data contained bothresolution_constrandreslution_constr, the latter of which has been removed from all test data - i assumeprojectClassToR1was used to generate the test data?)