Implements set custom path in CustomFile class#230
Merged
StephenNneji merged 2 commits intoRascalSoftware:masterfrom Jun 3, 2024
Merged
Implements set custom path in CustomFile class#230StephenNneji merged 2 commits intoRascalSoftware:masterfrom
StephenNneji merged 2 commits intoRascalSoftware:masterfrom
Conversation
StephenNneji
force-pushed
the
custom_file_path
branch
3 times, most recently
from
432d4cf to
bee166b
Compare
DrPaulSharp
reviewed
May 21, 2024
StephenNneji
force-pushed
the
custom_file_path
branch
2 times, most recently
from
9fcf27f to
16d067a
Compare
DrPaulSharp
reviewed
May 23, 2024
API/projectClass/customFileClass.m
Outdated
|
|
||
| if ~strcmp(results.name, obj.varTable{row, 1}{:}) | ||
| obj.setCustomName(row, results.name); | ||
| end |
Collaborator
There was a problem hiding this comment.
Why do these two fields have if statements checking they have changed whilst the others do not?
Collaborator
Author
There was a problem hiding this comment.
Because resetting the name led to a duplicate error but I will fix
StephenNneji
force-pushed
the
custom_file_path
branch
from
16d067a to
5f06657
Compare
DrPaulSharp
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.