Updates naming convention for main RAT variables#194
Merged
DrPaulSharp merged 9 commits intoRascalSoftware:masterfrom Jan 26, 2024
Merged
Updates naming convention for main RAT variables#194DrPaulSharp merged 9 commits intoRascalSoftware:masterfrom
DrPaulSharp merged 9 commits intoRascalSoftware:masterfrom
Conversation
StephenNneji
approved these changes
Jan 22, 2024
Collaborator
StephenNneji
left a comment
StephenNneji
left a comment
There was a problem hiding this comment.
Please see comments
API/RAT.m
Outdated
| @@ -1,44 +1,42 @@ | |||
| function [outProblemDef,result] = RAT(problemDefInput,controls) | |||
| function [project,result] = RAT(project,inputControls) | |||
Collaborator
There was a problem hiding this comment.
I think RAT(project, controls) is a better signature than RAT(project, inputControls) especially since this is the user facing function
Collaborator
Author
There was a problem hiding this comment.
I wanted to capture the fact that the controls are converted from a class object to a struct, but I'll take another look.
Collaborator
Author
There was a problem hiding this comment.
I think the lesser evil here is to leave it as controls throughout, despite the change in type. What do you think?
| function [fitPars,fitNames,fitConstr] = getFitValues(inputProblem,controls) | ||
|
|
||
| [problemDef,problemDef_cells,problemDef_limits,priors,controls] = RatParseClassToStructs_new(inputProblem,controls); | ||
| [problemStruct,problemCells,problemLimits,~,controls] = parseClassToStructs(inputProblem,controls); |
Collaborator
There was a problem hiding this comment.
is inputProblem meant to be project?
Collaborator
Author
There was a problem hiding this comment.
Yes, I largely left the examples as they are being replaced.
DrPaulSharp
force-pushed
the
variables
branch
from
c7336a8 to
caa517d
Compare
DrPaulSharp
force-pushed
the
variables
branch
from
caa517d to
c5e1dc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.