Conversation
25d2252 to
402edd3
Compare
DrPaulSharp
left a comment
There was a problem hiding this comment.
All looks good in general, but a bit of tidying up and resolving inconsistencies will help show the code off best.
In addition to the specific comments:
- There is no README for Domains/CustomXY
- There is mixed use of camelCase and snake_case for directories and variables
- The file "Normal_Reflectivity/Custom_XY/customDSPC.m" refers to old variables in the project - is this the correct version of the file?
- "testExamples.m" should be replaced with a new version, rather than just deleted.
25827d3 to
21ef173
Compare
21ef173 to
222e7a7
Compare
DrPaulSharp
left a comment
There was a problem hiding this comment.
Seems fine, just a few specific things to look at. I'd also ask again about the use of snake case for the directory names in the examples directory - should these not be camel case like the rest of the code?
I left it snake case for readability but folder names are simple enough so I will change to camel case for consistency. |
Makes a new set of examples for using the toolbox.