Skip to content

Updated examples#192

Merged
StephenNneji merged 3 commits intoRascalSoftware:masterfrom
arwelHughes:updated_examples
Jan 25, 2024
Merged

Updated examples#192
StephenNneji merged 3 commits intoRascalSoftware:masterfrom
arwelHughes:updated_examples

Conversation

@arwelHughes
Copy link
Collaborator

Makes a new set of examples for using the toolbox.

@StephenNneji StephenNneji force-pushed the updated_examples branch 4 times, most recently from 25d2252 to 402edd3 Compare January 18, 2024 15:27
Copy link
Collaborator

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good in general, but a bit of tidying up and resolving inconsistencies will help show the code off best.

In addition to the specific comments:

  • There is no README for Domains/CustomXY
  • There is mixed use of camelCase and snake_case for directories and variables
  • The file "Normal_Reflectivity/Custom_XY/customDSPC.m" refers to old variables in the project - is this the correct version of the file?
  • "testExamples.m" should be replaced with a new version, rather than just deleted.

@StephenNneji StephenNneji force-pushed the updated_examples branch 2 times, most recently from 25827d3 to 21ef173 Compare January 24, 2024 17:19
Copy link
Collaborator

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, just a few specific things to look at. I'd also ask again about the use of snake case for the directory names in the examples directory - should these not be camel case like the rest of the code?

@StephenNneji
Copy link
Collaborator

Seems fine, just a few specific things to look at. I'd also ask again about the use of snake case for the directory names in the examples directory - should these not be camel case like the rest of the code?

I left it snake case for readability but folder names are simple enough so I will change to camel case for consistency.

@StephenNneji StephenNneji merged commit 22df78b into RascalSoftware:master Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants