Unifies variable naming conventions#187
Merged
DrPaulSharp merged 11 commits intoRascalSoftware:masterfrom Jan 9, 2024
Merged
Conversation
StephenNneji
reviewed
Jan 3, 2024
Collaborator
StephenNneji
left a comment
StephenNneji
left a comment
There was a problem hiding this comment.
There are a lot of occurrences of shifted_dat still in the code please fix if possible.
please replace shifted_data in compile/events/eventManagerInterface.cpp with shiftedData
API/parseResultToStruct.m
Outdated
| result.shifted_data = results{3}; % Data corrected for sfs | ||
| result.simulation = results{2}; % Reflectivity between sim limits | ||
| result.shiftedData = results{3}; % Data corrected for sfs | ||
| result.layerSlds = results{4}; % Layers if defined (i.e. not custolXY) |
Collaborator
There was a problem hiding this comment.
typo: custolXY should be customXY
| function problemDef = unpackParams(problemDef,controls) | ||
|
|
||
| %Unpack the params out of the fitparsma and otherparams arrays | ||
| %Unpack the params out of the fitParamsma and otherparams arrays |
| @@ -1,14 +1,14 @@ | |||
| function [reflect,Simul,shifted_dat] = applyBackgroundCorrection(reflect,Simul,shifted_dat,backg,backsType) | |||
| function [reflect,simul,shifted_dat] = applyBackgroundCorrection(reflect,simul,shifted_dat,backgroundParams,contrastBackgroundsType) | |||
| @@ -1,4 +1,4 @@ | |||
| function [reflectivity, Simulation] = callReflectivity(bulkIns,bulkOuts,simLimits,repeatLayers,this_data,layers,ssubs,res,parallel,refType,useImaginary) | |||
| function [reflectivity, simulation] = callReflectivity(bulkIns,bulkOuts,simLimits,repeatLayers,this_data,layers,ssubs,res,parallel,refType,useImaginary) | |||
Collaborator
There was a problem hiding this comment.
missed res also this_data
StephenNneji
approved these changes
Jan 9, 2024
testScript.m
Outdated
| @@ -1,3 +1,4 @@ | |||
|
|
|||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.