Fix training cache bug in rasa init
#9990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2021 12:57
Fixes #9922 When using `rasa init` with a new project directory to be created, current directory was used for caching training data. This meant `.rasa` was created in the directory `rasa init` is run; this resulted in cache directory not in project directory and also that if model training was done, this cache directory was not utilized later on. This PR fixes this by changing into the project directory and then continuing scaffolding and training afterwards.
tayfun
requested review from
aeshky,
wochinge and
a team
and removed request for
a team
wochinge
reviewed
Oct 27, 2021
changelog/9922.bugfix.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| Fix the directory where caching files are created. This was wrongly the | |||
There was a problem hiding this comment.
optional: Up to you but in my opinion we don't even need a changelog as this wasn't even released yet
There was a problem hiding this comment.
Agreed that we don't need this changelog - might be confusing.
added 2 commits
October 27, 2021 13:20
wochinge
reviewed
Oct 27, 2021
tests/cli/test_rasa_init.py
Outdated
| Tests cache directories for training data are in project root, not | ||
| where `rasa init` is run. | ||
| """ | ||
| run_with_stdin("init", stdin=b"test-project\n\n\nno\n") |
There was a problem hiding this comment.
mhm, I saw your comment on Slack re the timing issues. How about we go through print_train_or_instructions instead of the CLI so we can monkeypatch things to use a quicker model config?
added 8 commits
October 28, 2021 15:13
aeshky
approved these changes
Oct 29, 2021
joejuzl
approved these changes
Oct 29, 2021
changelog/9922.bugfix.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| Fix the directory where caching files are created. This was wrongly the | |||
There was a problem hiding this comment.
Agreed that we don't need this changelog - might be confusing.
tayfun
deleted the
tayfun/9922-fix-rasa-init-cache-directory-with-chdir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9922
When using
rasa initwith a new project directory to be created,current directory was used for caching training data. This meant
.rasawas created in the directory
rasa initis run; this resulted in cachedirectory not in project directory and also that if model training was
done, this cache directory was not utilized later on.
This PR fixes this by changing into the project directory and then
continuing scaffolding and training afterwards.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)