Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success Markers CLI #9824

Merged
merged 20 commits into from
Nov 1, 2021
Merged

Success Markers CLI #9824

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
778a69b
Create stubs to start filling out Aciel's snippet
usc-m Oct 6, 2021
186a1e4
Sketch out basics of CLI arguments
usc-m Oct 7, 2021
6a90fc2
Start changing over args to new format
usc-m Oct 20, 2021
a6e29e9
Make CLI match description from design pass
usc-m Oct 22, 2021
7ed690e
Add tests
usc-m Oct 27, 2021
e4dd4fc
Switch over timestamps to event IDs
usc-m Oct 27, 2021
bf4030b
Fix tests now event IDs are supported
usc-m Oct 27, 2021
ab8d3f2
Start work on doc comments
usc-m Oct 27, 2021
a70d06a
Switch over event_id fix
usc-m Oct 28, 2021
1d45b90
Address PR comments
usc-m Oct 28, 2021
3aa624d
Fix incorrect file extension
usc-m Oct 28, 2021
441ccc5
Codeclimate
usc-m Oct 28, 2021
10d8360
Update rasa/core/evaluation/marker_base.py
usc-m Oct 29, 2021
65fad80
Address PR comments
usc-m Oct 29, 2021
f630721
Move test to marker
usc-m Oct 29, 2021
60cedb4
Merge branch 'main' into 9658/success-markers-cli
usc-m Oct 29, 2021
d6d1321
Rename dialogue to session
usc-m Oct 29, 2021
e686a3c
Merge branch 'main' into 9658/success-markers-cli
aeshky Nov 1, 2021
86ddf76
Fix types, fix CLI test
usc-m Nov 1, 2021
036a0a1
Fix types again
usc-m Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests now event IDs are supported
  • Loading branch information
@usc-m
usc-m committed Oct 28, 2021
commit bf4030bca4904d7e991498d3b56a00e1d6765840
4 changes: 2 additions & 2 deletions tests/cli/test_rasa_evaluate_markers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,12 @@ def test_markers_cli_results_save_correctly(
senders.add(row["sender_id"])
if row["marker_name"] == "marker1":
assert row["dialogue_id"] == "0"
# assert row["event_id"] == "1"
assert int(row["event_id"]) >= 2
assert row["num_preceding_user_turns"] == "0"

if row["marker_name"] == "marker2":
assert row["dialogue_id"] == "1"
# assert row["event_id"] == "2"
assert int(row["event_id"]) >= 3
assert row["num_preceding_user_turns"] == "1"

assert len(senders) == 5