-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read TF version from poetry.lock #9785
Conversation
Hey @HotThoughts! 👋 To run model regression tests, comment with the Tips 💡: The model regression test will be run on Tips 💡: Every time when you want to change a configuration you should edit the comment with the previous configuration. You can copy this in your comment and customize:
|
/modeltest include:
- dataset: ["Carbon Bot"]
config: ["Sparse + DIET(bow) + ResponseSelector(bow)"]
|
The model regression tests have started. It might take a while, please be patient. Used configuration can be found in the comment. |
Commit: 51c17fb, The full report is available as an artifact. Dataset:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The problem:
We were using
sed
-style to read TF version frompyproject.toml
, which leads us to problems when the version constraints aren't cover in the sed command. We need to find a way to read TensorFlow version frompoetry.lock
directly.Proposed changes:
Use python's toml library to parse and read TensorFlow version from
poetry.lock
.It now uses the new
read_tenforflow_version.sh
script to retrieve tf version (e.g.2.6
) and CUDA/cuDNN libraries successfully load.