Fix and enable mypy return check #9109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joejuzl
requested review from
a team and
koernerfelicia
and removed request for
a team and
koernerfelicia
ancalita
reviewed
Jul 13, 2021
| @@ -165,6 +165,7 @@ def run_core_training( | |||
| rasa.utils.common.run_in_loop( | |||
| do_compare_training(args, story_file, additional_arguments) | |||
| ) | |||
| return None | |||
There was a problem hiding this comment.
I'm not very sure what do_compare_training does, but it also returns None, is there any reason why it shouldn't be return rasa.utils.common.run_in_loop(...)?
wochinge
reviewed
Jul 14, 2021
rasa/core/policies/sklearn_policy.py
Outdated
| @@ -338,7 +338,7 @@ def persist(self, path: Union[Text, Path]) -> None: | |||
| @classmethod | |||
| def load( | |||
| cls, path: Union[Text, Path], should_finetune: bool = False, **kwargs: Any | |||
| ) -> Policy: | |||
| ) -> Optional[Policy]: | |||
There was a problem hiding this comment.
we can't do this @joejuzl as this goes against the Policy interface
There was a problem hiding this comment.
haha yes true. TEDPolicy.load was recently changed to have return cls(). We can do that here too.
ancalita
reviewed
Jul 15, 2021
ancalita
reviewed
Jul 15, 2021
ancalita
reviewed
Jul 15, 2021
ancalita
reviewed
Jul 15, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Fixes #8242