Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dense dimension sparse input #6563

Merged
merged 17 commits into from
Sep 8, 2020
Merged

Dense dimension sparse input #6563

merged 17 commits into from
Sep 8, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented Sep 3, 2020

Proposed changes:
Do not set the output dimension of the sparse-to-dense layers to the same dimension as the dense features.

closes #6555

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2020

Commit: 96a529d, The full report is available as an artifact.

Dataset: Carbon Bot

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)
test: 42s, train: 3m45s, total: 4m27s
0.8388 0.6260 0.5894
Sparse + DIET(bow) + ResponseSelector(bow)
test: 19s, train: 2m43s, total: 3m1s
0.7417 0.6260 0.4651

Dataset: Hermit

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)
test: 1m23s, train: 23m19s, total: 24m41s
0.8866 0.7487 no data
Sparse + DIET(bow) + ResponseSelector(bow)
test: 35s, train: 19m16s, total: 19m50s
0.8281 0.7487 no data

Dataset: Sara

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)
test: 1m3s, train: 7m44s, total: 8m47s
0.8981 0.8683 0.9283
Sparse + DIET(bow) + ResponseSelector(bow)
test: 27s, train: 5m18s, total: 5m44s
0.8139 0.8683 0.8522

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020

Commit: 83c9305, The full report is available as an artifact.

Dataset: Carbon Bot

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)
test: 41s, train: 3m40s, total: 4m21s
0.8272 0.6260 0.6026
Sparse + DIET(bow) + ResponseSelector(bow)
test: 21s, train: 2m43s, total: 3m4s
0.7437 0.6260 0.5033

Dataset: Hermit

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)
test: 1m20s, train: 23m25s, total: 24m45s
0.8931 0.7487 no data
Sparse + DIET(bow) + ResponseSelector(bow)
test: 35s, train: 19m25s, total: 20m0s
0.8290 0.7487 no data

Dataset: Sara

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)
test: 1m3s, train: 7m51s, total: 8m54s
0.8981 0.8683 0.9196
Sparse + DIET(bow) + ResponseSelector(bow)
test: 28s, train: 5m17s, total: 5m44s
0.8384 0.8683 0.8413

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020

Commit: 73f5d12, The full report is available as an artifact.

Dataset: Carbon Bot

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)
test: 45s, train: 4m5s, total: 4m49s
0.8485 0.6260 0.5430
Sparse + DIET(bow) + ResponseSelector(bow)
test: 20s, train: 2m53s, total: 3m13s
0.7223 0.6260 0.4967

Dataset: Hermit

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + DIET(bow) + ResponseSelector(bow)
test: 37s, train: 20m0s, total: 20m36s
0.8253 0.7487 no data

Dataset: Sara

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)
test: 1m7s, train: 8m13s, total: 9m19s
0.8962 0.8683 0.9217
Sparse + DIET(bow) + ResponseSelector(bow)
test: 28s, train: 5m44s, total: 6m11s
0.8335 0.8683 0.8261

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020

/modeltest

include:
 - dataset: 
      - "Carbon Bot"
      - "Sara"
   config:
      - "Sparse + DIET(bow) + ResponseSelector(bow)"
      - "Sparse + DIET(seq) + ResponseSelector(bow)"
      - "Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)"
      - "Sparse + ConveRT + DIET(seq) + ResponseSelector(bow)"
      - "Sparse + Spacy + DIET(bow) + ResponseSelector(bow)"
      - "Sparse + Spacy + DIET(seq) + ResponseSelector(bow)"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020

Commit: 9e65197, The full report is available as an artifact.

Dataset: Carbon Bot

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)
test: 43s, train: 3m50s, total: 4m32s
0.8369 0.6260 0.5960
Sparse + DIET(bow) + ResponseSelector(bow)
test: 20s, train: 2m45s, total: 3m4s
0.7340 0.6260 0.5298

Dataset: Sara

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1
Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)
test: 1m2s, train: 7m56s, total: 8m58s
0.8874 0.8683 0.9283
Sparse + DIET(bow) + ResponseSelector(bow)
test: 28s, train: 5m34s, total: 6m1s
0.8325 0.8683 0.8522

@tabergma tabergma requested a review from Ghostvv September 7, 2020 07:13
@RasaHQ RasaHQ deleted a comment from github-actions bot Sep 7, 2020
@RasaHQ RasaHQ deleted a comment from github-actions bot Sep 7, 2020
@tabergma
Copy link
Contributor Author

tabergma commented Sep 7, 2020

Results match those from the master branch (see https://metabase.rasa.com/dashboard/166)

@@ -72,6 +71,7 @@
TENSORBOARD_LOG_LEVEL,
CONCAT_DIMENSION,
FEATURIZERS,
DENSE_DIMENSION,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in response selector, 128 is not enough?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we changed it to predict labels, it is basically another DIET

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I set it to something lower, the performance dropped (see the tables above).

Copy link
Contributor

@Ghostvv Ghostvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did it reduce train run time for DIET?

@tabergma
Copy link
Contributor Author

tabergma commented Sep 7, 2020

The train time for Sparse + ConveRT + DIET(bow) + ResponseSelector(bow) increased for Sara and Carbon Bot by a couple of seconds. Without ConveRT it stayed the same.

@rasabot rasabot merged commit 1478b39 into master Sep 8, 2020
@rasabot rasabot deleted the dense-dimension-sparse-input branch September 8, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dense dimension of a sparse input shouldn't be set to a dimension of a dense input
3 participants