-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dense dimension sparse input #6563
Conversation
Commit: 96a529d, The full report is available as an artifact. Dataset:
Dataset:
Dataset:
|
Commit: 83c9305, The full report is available as an artifact. Dataset:
Dataset:
Dataset:
|
Commit: 73f5d12, The full report is available as an artifact. Dataset:
Dataset:
Dataset:
|
/modeltest include:
- dataset:
- "Carbon Bot"
- "Sara"
config:
- "Sparse + DIET(bow) + ResponseSelector(bow)"
- "Sparse + DIET(seq) + ResponseSelector(bow)"
- "Sparse + ConveRT + DIET(bow) + ResponseSelector(bow)"
- "Sparse + ConveRT + DIET(seq) + ResponseSelector(bow)"
- "Sparse + Spacy + DIET(bow) + ResponseSelector(bow)"
- "Sparse + Spacy + DIET(seq) + ResponseSelector(bow)" |
Commit: 9e65197, The full report is available as an artifact. Dataset:
Dataset:
|
Results match those from the master branch (see https://metabase.rasa.com/dashboard/166) |
@@ -72,6 +71,7 @@ | |||
TENSORBOARD_LOG_LEVEL, | |||
CONCAT_DIMENSION, | |||
FEATURIZERS, | |||
DENSE_DIMENSION, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in response selector, 128
is not enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we changed it to predict labels, it is basically another DIET
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I set it to something lower, the performance dropped (see the tables above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did it reduce train run time for DIET?
The train time for |
Proposed changes:
Do not set the output dimension of the
sparse-to-dense
layers to the same dimension as the dense features.closes #6555
Status (please check what you already did):
black
(please check Readme for instructions)